Fixes #23074: Generation not queued when one already started #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
approved these changes
Jul 17, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 1cd552a
into
Normation:branches/rudder/7.2
16 checks passed
fanf
deleted the
bug_23074/generation_not_queued_when_one_already_started
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23074
In PR https://github.com/Normation/rudder/pull/4832/files#diff-2bfd5f67b4c377de308d2c78906f3ecf1684b561fc7c22739dfd18aea93156afL275 we removed the actual queuing, not only the save of log event, which breaks the state machine.