Fixes #23090: Multiline string in component name or value breaks pattern comparison for expected report #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ern comparison for expected report
VinceMacBuche
approved these changes
Jul 19, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit df05710
into
Normation:branches/rudder/7.2
16 checks passed
fanf
deleted the
bug_23090/multiline_string_in_component_name_or_value_breaks_pattern_comparison_for_expected_report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23090
Our regex for matching what is expanded from an variable didn't have the "dot all" modifier, which makes it unable to match multiline string.