Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23093: Warning for unused vars in 8.0 compilation #4902

Conversation

fanf
Copy link
Member

@fanf fanf commented Jul 19, 2023

https://issues.rudder.io/issues/23093

Rights were used in the angular app, now it's fully managed from elm side of the rewritten app, see: #4839

@fanf fanf requested a review from VinceMacBuche July 19, 2023 15:27
@@ -43,7 +43,7 @@ import com.normation.plugins.DefaultExtendableSnippet
import com.normation.rudder.AuthorizationType
import com.normation.rudder.domain.nodes._
import com.normation.rudder.domain.policies._
import com.normation.rudder.domain.queries.Query
qqimport com.normation.rudder.domain.queries.Query
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qqimport ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course i did that after I tested for compilation and formated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's always like that !!

@fanf
Copy link
Member Author

fanf commented Jul 19, 2023

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/4902
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/71271/console)

@fanf
Copy link
Member Author

fanf commented Jul 24, 2023

OK, squash merging this PR

@fanf fanf force-pushed the bug_23093/warning_for_unused_vars_in_8_0_compilation branch from b9bd093 to 2f57f4f Compare July 24, 2023 14:33
@fanf fanf merged commit 2f57f4f into Normation:branches/rudder/8.0 Jul 24, 2023
@fanf fanf deleted the bug_23093/warning_for_unused_vars_in_8_0_compilation branch March 15, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants