Fixes #23120: Refactor TechniqueReader code #4906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
amousset
reviewed
Jul 21, 2023
webapp/sources/rudder/rudder-web/src/main/scala/bootstrap/liftweb/RudderConfig.scala
Outdated
Show resolved
Hide resolved
amousset
approved these changes
Jul 24, 2023
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
…web/RudderConfig.scala Co-authored-by: Alexis Mousset <alexis.mousset@rudder.io>
amousset
force-pushed
the
arch_23120/refactor_techniquereader_code
branch
from
53c37f9
to
f529681
Compare
amousset
merged commit f529681
into
Normation:branches/rudder/8.0
0 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23120
Pure refactoring. It does:
TechniqueReaderalong with other technique editor things likeTechniqueWriter, etcgeneric_methods.jsonto zio json and add a test that it at least knows how to read the currect 7.3 (rudder base + dsc) generic methods