Fixes #4403: allow to configure LDAP authentication from property file #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # login by the user. | ||
| # | ||
| rudder.auth.ldap.searchbase=ou=People | ||
| rudder.auth.ldap.filter=(&(uuid={0})(objectclass=person)) |
There was a problem hiding this comment.
Please change this line to replace uuid by uid. This is not a valid LDAP example and I just know it will cause us pain the future.
For simplicity feel free to merge as is and change that afterwards. This is urgent.
|
looks good to me ! thank oyu Francois |
ncharles
added a commit
that referenced
this pull request
Mar 27, 2014
…erty_file Fixes #4403: allow to configure LDAP authentication from property file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main painful part was to understand that we must have system properties to be able to use them at the time the import is resolve.
Perphaps a better solution would have been to configure everything in code, but the spring-security part is awful.