Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #23159: Use the secrecy crate for wrapping passwords #4927

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fixes #23159: Use the secrecy crate for wrapping passwords #4927

merged 1 commit into from
Jul 31, 2023

Conversation

amousset
Copy link
Member

@amousset amousset commented Jul 30, 2023 •
edited
Loading

https://issues.rudder.io/issues/23159

Improves secret security:

  • Zero-ed memory on Drop
  • Immutable secrets (avoid accidental copies)
  • No access possible outside of expose_secret(), even for only a comparison
  • expose_secret() is more explicit than value()

@amousset amousset requested a review from Fdall July 30, 2023 18:56
@amousset amousset changed the title Fixes #23159: Use the secrecy crates for wrapping passwords Fixes #23159: Use the secrecy crate for wrapping passwords Jul 30, 2023
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

OK, squash merging this PR

@amousset amousset force-pushed the arch_23159/use_the_secrecy_crates_for_wrapping_passwords branch from 7c2457e to bb1d59b Compare July 31, 2023 08:26
@amousset amousset merged commit bb1d59b into Normation:branches/rudder/8.0 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdall Fdall Fdall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@amousset @Fdall