Fixes #23201: Rewrite angular app tags.js in Elm #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
RaphaelGauthier
force-pushed
the
bug_23201/rewrite_angular_app_tags_js_in_elm
branch
from
9655f50
to
4c53402
Compare
amousset
reviewed
Aug 2, 2023
| init : { contextPath : String, hasWriteRights : Bool, tags : List Tag, filterId : String, isEditForm : Bool, isRule : Bool, objectId : String } -> ( Model, Cmd Msg ) | ||
| init flags = | ||
| let | ||
| objectType = if flags.isRule then "rule" else "directive" |
There was a problem hiding this comment.
I'd rather have init take an objectType string directly instead of a boolean if it's not too much work
amousset
approved these changes
Aug 2, 2023
|
@RaphaelGauthier missing spotless pass |
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
RaphaelGauthier
force-pushed
the
bug_23201/rewrite_angular_app_tags_js_in_elm
branch
from
0930da4
to
da30544
Compare
RaphaelGauthier
merged commit da30544
into
Normation:branches/rudder/8.0
0 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23201