New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #23234: Hash API tokens #4971
Fixes #23234: Hash API tokens #4971
Conversation
Fixes #23234: Hash API tokens
PR updated with a new commit |
Fixes #23234: Hash API tokens
PR updated with a new commit |
Fixes #23234: Hash API tokens
PR updated with a new commit |
Fixes #23234: Hash API tokens
PR updated with a new commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm (comments were made and addressed in previous pr)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
- using old token
- creating new token
- migrating token
- user token
- new token with API ACLS
Everything works great, message are 👍 , and all code related topic were previously addressed.
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
https://issues.rudder.io/issues/23234
See https://www.notion.so/rudderio/Hash-des-tokens-d-API-ddb9ec15820e4a81875b2a235d3f32e5 for details.
Technically, in the webapp:
ApiToken
. This will ease future modifications and ensure consistency.The frontend changes are straightforward: