Fixes #23305: When custom role permission list is empty, reload lead to stack trace #4990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
approved these changes
Aug 21, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit ba3e72a
into
Normation:branches/rudder/7.3
15 checks passed
fanf
deleted the
bug_23305/when_custom_role_permission_list_is_empty_reload_lead_to_stack_trace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23305
We used to forbid creation of a rights without any
Authorization- which is good ! But the correct way to forbid it is by making creation impossible, not throwing a runtime error.This PR change the
Rightsclass to a case class but with a private constructor to force the use of its object factory which does the correct checking and succeed in all case, returning theNoRightsspecial value if needed.Remaining part of the PR are change to accomodate the use of the factory in place of
new.All over, it's a nice simplification.
PR Normation/rudder-plugins#593 needs that one before being merged.