Fixes #23322: Add back RUDDER_VERIFY_CERTIFICATES to rudder.json #4994
Conversation
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
| systemVariableSpecService.get("RUDDER_COMPLIANCE_MODE").toVariable(Seq(agentPolicyMode.name)) | ||
| systemVariableSpecService.get("RUDDER_COMPLIANCE_MODE").toVariable(Seq(agentPolicyMode.name)), | ||
| // For compatibility with pre-8.0 agents | ||
| systemVariableSpecService.get("RUDDER_VERIFY_CERTIFICATES").toVariable(Seq("false")) |
There was a problem hiding this comment.
You need to revert what was in SystemVariableSpecImpl (https://github.com/Normation/rudder/pull/4982/files#diff-b2bb87fe54627ab29d48267c7a88d069948c01442c48aeeaeaa1104cb1e441a6) to have that working
There was a problem hiding this comment.
Perhaps you can create the spec it here in an ad-hoc way with a comment "for compat, will be removed in 8.1" (or when it's time)
There was a problem hiding this comment.
The tests seem to pass without it, is it expected?
There was a problem hiding this comment.
No ? (I'm not even sure why you didn't get a "missing system variable spec" error)
|
PR updated with a new commit |
2 similar comments
|
PR updated with a new commit |
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
amousset
force-pushed
the
bug_23322/add_back_rudder_verify_certificates_to_rudder_json
branch
from
48ad3aa
to
82ffe82
Compare
https://issues.rudder.io/issues/23322
7.X agents still read this value, we need to provide it. Usage in agent is removed in Normation/rudder-agent#387 and Normation/rudder-plugins#595.