Fixes #23325: Simplify YAML encoding workaround #4996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
approved these changes
Aug 23, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 0b57d43
into
Normation:branches/rudder/8.0
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23325
As far as I saw, the only change was the addition of
dumperOptions.setIndentWithIndicator(true), so I removed everything else that was possible to rely on what the lib provide and avoid duplicating code.I also reodered code so that it follows the original one and make comparison easier.
I've added a test so that we are informed if at some point, the base lib bug is corrected (and that our encoder works).
Alse change licence header (that's not our copyright, we copied it, so it must be said, even if the original license allows that).