Fixes #23352: Import/Export yaml with technique editor #5008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
added
WIP
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_23352/import_export_yaml_with_technique_editor
branch
from
1b69246
to
22b4e12
Compare
fanf
reviewed
Aug 30, 2023
| @@ -780,7 +816,7 @@ class TechniqueAPIService14( | |||
| techniqueRevisions.getTechniqueRevision(name, version).map(_.map(JRRevisionInfo.fromRevisionInfo)) | |||
| } | |||
|
|
|||
| def getTechniqueWithData(techniqueName: TechniqueName, version: Option[TechniqueVersion]) = { | |||
| def getTechniqueWithData(techniqueName: TechniqueName, version: Option[TechniqueVersion], format: String) = { | |||
There was a problem hiding this comment.
format should not be a string there
fanf
reviewed
Aug 30, 2023
|
OK, actually export works too, elm just needed to be recompiled/reloaded. So just the format thing, and self merge! |
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_23352/import_export_yaml_with_technique_editor
branch
from
22b4e12
to
fbf7f58
Compare
VinceMacBuche
force-pushed
the
bug_23352/import_export_yaml_with_technique_editor
branch
from
fbf7f58
to
2831d46
Compare
|
OK, merging this PR |
VinceMacBuche
merged commit b59208e
into
Normation:branches/rudder/8.0
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23352
Adds a new API to check whether a technique is valid or not (accepts a yaml, returns a json) to use to import a yaml technique
Modify getTechnique api to add a format parameter to return a yaml instead of a json to use to export a technique as yaml
modify the technique editor to use both new api/parameters