Fixes #23372: Add a way to set a message if "change audit logs" setting is enabled #5027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaphaelGauthier
force-pushed
the
bug_23372/add_a_way_to_set_a_message_if_change_audit_logs_setting_is_enabled
branch
from
45d1be0
to
d90c77d
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_23372/add_a_way_to_set_a_message_if_change_audit_logs_setting_is_enabled
branch
from
2d412b9
to
e39612c
Compare
|
This PR is not mergeable to upper versions. |
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_23372/add_a_way_to_set_a_message_if_change_audit_logs_setting_is_enabled
branch
from
e39612c
to
1adffe9
Compare
VinceMacBuche
approved these changes
Sep 12, 2023
|
OK, merging this PR |
VinceMacBuche
merged commit 1adffe9
into
Normation:branches/rudder/7.3
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23372
Putting back the change audit message / change request popup after it was removed when the rules interface was rewritten in version 7.0.
We want to control this popup in Elm, so we're rewriting an Elm module to handle change requests and change audit messages, which we're integrating into the Rules application.
The interface is almost identical to what existed before, the aim here is not to improve the user experience but to restore this functionality which had disappeared.