Fixes #23382: Improve display of YAML code #5029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
force-pushed
the
ust_23382/improve_display_of_yaml_code
branch
from
1d49e1a
to
8921174
Compare
VinceMacBuche
approved these changes
Sep 6, 2023
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23382
Simple styling to get it to look more like a code editor. Syntax highlighting is quite tricky as https://github.com/pablohirafuji/elm-syntax-highlight does not support YAML (and seems to be the only pure Elm solution) and JS-based solutions (like hightlight.js) mess with the DOM.
Before: