Fixes #23555: When migrating json technique to yaml, canonify parameter name #5090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
bug_23555/when_migrating_json_technique_to_yaml_canonify_parameter_name
branch
from
0b22869
to
8fd455f
Compare
|
I don't think that what we want. As discussed in our notion with @amousset We'd like to make "name" to be the canonified name of the parameter and "description" be the current name so that we don't create new fields anymore and the mapping to yaml is direct. So migration from 7.3 should: take the name, use it as description, and canonify it to use it as name |
|
i made a PR : https://github.com/fanf/rudder/pull/15/files |
fanf
force-pushed
the
bug_23555/when_migrating_json_technique_to_yaml_canonify_parameter_name
branch
from
b09b8fa
to
7c333da
Compare
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 7c333da
into
Normation:branches/rudder/8.0
15 checks passed
fanf
deleted the
bug_23555/when_migrating_json_technique_to_yaml_canonify_parameter_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23555
Principal changes:
variableNameinEditorTechnique -> parameters. This is the canonified version of the parameter, the one used in .cf and .ps1 files,canonifyfromNcfIdsince we now have access to it in technique param directlynamefor params, and put the result invariableNamenameto editorvariableName, anddescriptionto editornameI didn't touch
JResponseObject, they will likely need to be updated to addvariableNamefield etc