Fixes #23587: Add checks annd validation on parameter name #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
Oct 17, 2023
| @@ -62,26 +63,38 @@ techniqueParameter model technique param opened = | |||
| ( "Parameter cannot be empty and needs a value.\nIf you add a parameter to an existing technique, policy generation will fail and you will need to update all directives with the new parameter value" | |||
| , "btn-info" | |||
| ) | |||
| (invalidParamClass, invalidParamElem) = | |||
| if (Regex.contains ((Regex.fromString >> Maybe.withDefault Regex.never) "[^_a-zA-Z\\d]") param.name) then | |||
| ("error", ul [class "row"] [ li [ class "text-danger col-sm-8" ] [ text "Invalid variable name is required, valid characters are [_a-zA-Z\\d]" ] ] ) | |||
There was a problem hiding this comment.
could you write it in a nicer way ?
Like "The variable name is invalid, only alphanumerical characters and _ are accepted" ?
amousset
approved these changes
Oct 17, 2023
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23587