Fixes #23607: When a mandatory field in a technique is not defined, we can save a technique and we have a nasty error #5118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23607
In 8.0, rudderc has (inadvertently) changed the output format from a list of plain strings to a list of
And regex from a string to:
This change was not expected in the webapp, but the parser for this file was rewritten at the same time, with a typo on the constraint key name (
constraint
instead ofconstraints
), which lead to totally ignoring constraints (and hide the error).As the change in rudderc was made to improve consistency with select parameter type in techniques, this PR changes the expected format on the webapp side. We can do this as rudderc and the webapp come in the same package and are always in sync.
This PR fixes the checks on parameters in the editor:
Also adding an annotation in rudderc to avoid the null
error_message
in regex: