Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #23657: Compiler warnings should prevent build #5139

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fixes #23657: Compiler warnings should prevent build #5139

merged 1 commit into from
Nov 15, 2023

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Oct 26, 2023 •
edited
Loading

https://issues.rudder.io/issues/23657

"match may not be exhaustive" compiler warning should be an error 馃槺

Edit : I had to fix other warnings such as unused imports

@clarktsiory
Copy link
Contributor Author

Commit modified

@clarktsiory clarktsiory force-pushed the bug_23657/compiler_warnings_should_prevent_build branch from 5f51484 to b36020a Compare October 26, 2023 09:37
VinceMacBuche
VinceMacBuche reviewed Oct 26, 2023
View reviewed changes
webapp/sources/pom.xml Outdated
<arg>-language:existentials</arg> <!-- Existential types (besides wildcard types) can be written and inferred -->
<arg>-language:higherKinds</arg> <!-- Allow higher-kinded types -->
<arg>-language:implicitConversions</arg> <!-- Allow definition of implicit functions called views -->
<arg>-Xcheckinit</arg> <!-- Wrap field accessors to throw an exception on uninitialized access. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing all these flags ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had an issue with my IDE which auto-formats the pom.xml, and I didn't check the diff ^^

@clarktsiory
Copy link
Contributor Author

Commit modified

@clarktsiory clarktsiory force-pushed the bug_23657/compiler_warnings_should_prevent_build branch from b36020a to 3b45b6a Compare October 26, 2023 09:44
@clarktsiory
Copy link
Contributor Author

clarktsiory commented Oct 26, 2023 •
edited
Loading

PR updated with a new commit

Handled the line where there was a non-exhaustive match in this PR (it needs to be merged before this one)

@clarktsiory clarktsiory force-pushed the bug_23657/compiler_warnings_should_prevent_build branch from 52ddfb5 to 3b45b6a Compare October 26, 2023 14:19
@clarktsiory
Copy link
Contributor Author

PR rebased

@clarktsiory clarktsiory force-pushed the bug_23657/compiler_warnings_should_prevent_build branch from 3b45b6a to d0ce5e6 Compare October 27, 2023 07:52
@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

@fanf
Copy link
Member

fanf commented Nov 15, 2023

Let's go!

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5139
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/76162/console)

@fanf
Copy link
Member

fanf commented Nov 15, 2023

OK, squash merging this PR

@fanf fanf force-pushed the bug_23657/compiler_warnings_should_prevent_build branch from 9698066 to e016aaf Compare November 15, 2023 12:54
@fanf fanf merged commit e016aaf into Normation:branches/rudder/7.3 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche left review comments

@fanf fanf fanf approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
4 participants
@clarktsiory @fanf @Normation-Quality-Assistant @VinceMacBuche