Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23687: Add version parsing to rudder-package #5150

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Nov 2, 2023

@Fdall Fdall requested a review from amousset November 2, 2023 16:33
@Fdall
Copy link
Contributor Author

Fdall commented Nov 2, 2023

PR updated with a new commit

@Fdall
Copy link
Contributor Author

Fdall commented Nov 3, 2023

PR updated with a new commit

@Fdall
Copy link
Contributor Author

Fdall commented Nov 3, 2023

PR rebased

@Fdall Fdall force-pushed the ust_23687/add_version_parsing_to_rudder_package branch from 553d11a to f1a0100 Compare November 3, 2023 14:02
@amousset
Copy link
Member

amousset commented Nov 3, 2023

missing fmt

@Fdall
Copy link
Contributor Author

Fdall commented Nov 3, 2023

PR updated with a new commit

@Fdall
Copy link
Contributor Author

Fdall commented Nov 3, 2023

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5150
-- Your faithful QA
Kant merge: "To be is to do."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/75671/console)

@amousset
Copy link
Member

amousset commented Nov 3, 2023

OK, squash merging this PR

@amousset amousset force-pushed the ust_23687/add_version_parsing_to_rudder_package branch from 3831cb6 to f338851 Compare November 3, 2023 15:16
@amousset amousset merged commit f338851 into Normation:master Nov 3, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants