Fixes #23707: Implement common zio-json utils for plugins in rudder #5163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Nov 9, 2023
.../sources/rudder/rudder-rest/src/main/scala/com/normation/rudder/rest/RudderJsonRequest.scala
Show resolved
Hide resolved
fanf
reviewed
Nov 9, 2023
.../sources/rudder/rudder-rest/src/main/scala/com/normation/rudder/rest/RudderJsonRequest.scala
Outdated
Show resolved
Hide resolved
|
You need to add a description explaining the architecture/implem choice and - if needed - impact. |
fanf
requested changes
Nov 9, 2023
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
fanf
approved these changes
Nov 13, 2023
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
arch_23707/implement_common_zio_json_utils_for_plugins_in_rudder
branch
from
69d67e3
to
1100c15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23707
It is about moving code from a plugin, because it needs to be shared by many plugins and also probably in the API endpoints definitions when migrating lift-json to zio-json...