Bug #23671 : Locale issue: date picker outputs date in wrong order #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
previously approved these changes
Nov 27, 2023
|
Commits are not well formed !! |
ElaadF
force-pushed
the
23671_date_picker_wrong_format_in_group_criteria
branch
from
93d391a
to
eef3bc9
Compare
VinceMacBuche
approved these changes
Nov 27, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit eef3bc9
into
Normation:branches/rudder/7.3
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23671
This is a simple fix, it only affects the JavaScript date picker module in group criteria that was not sync with the expected defined format in the backend to
dd/MM/yyyy.In this case, this bug affects the criteria
Last inventory datein group criteria page. It appears that the format of inventory date is like2023-08-17 14:31:49+0200so to the formatyyyy/mm/dd.I think the date picker should use the same format. Despite the fact that the date picker and the inventory date doesn't use the same format, this PR fix the problem and the filter seems to work
This is not an ideal solution since we use the format
yyyy/mm/ddin general in the interface, but changing the format in the backend, means higher risk of breaking anything else, and we should consider refactoring this part and think about what standard we want to apply everywhere to be consistent.Here there are some ideas about what can we do to change the format in backend: #5157