Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23802: rudderc should export a technique with ids #5210

Conversation

amousset
Copy link
Member

@amousset amousset commented Nov 28, 2023

https://issues.rudder.io/issues/23802

  • Remove the export subcommand as we now need to be able to build the techniques, hence identical parameters to build, so it becomes an option of the build command
  • Fix condition serialization. For some reason the false condition was serialized to null.
  • Run export test on all test techniques, and also check validity of the technique.ids.yml file by re-building it.

@amousset amousset requested a review from Fdall November 28, 2023 19:51
@amousset
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5210
-- Your faithful QA
Kant merge: "Two things awe me most, the starry sky above me and the moral law within me."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/76878/console)

@amousset
Copy link
Member Author

OK, squash merging this PR

@amousset amousset force-pushed the bug_23802/rudderc_should_export_a_technique_with_ids branch from bcbfea9 to a01d290 Compare November 30, 2023 08:28
@amousset amousset merged commit a01d290 into Normation:branches/rudder/8.0 Nov 30, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants