Fixes #23790: Since the bootstrap 5 update, modals no longer open #5220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaphaelGauthier
added
the
WIP
|
Don't merge yet, there's still one case to be dealt with: modals generated in the topbar, they appear under the overlay, making them unusable :
|
|
PR updated with a new commit |
|
PR can be merge now, the last case has been fixed ! |
RaphaelGauthier
removed
the
WIP
|
Commit modified |
RaphaelGauthier
force-pushed
the
bug_23790/since_the_bootstrap_5_update_modals_no_longer_open
branch
from
94c4869
to
f5e9d8a
Compare
VinceMacBuche
approved these changes
Dec 4, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 493bc2d
into
Normation:master
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23790