Fixes #23818: Import archive for an existing technique delete the previous technique #5224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit bd3ac6e
into
Normation:branches/rudder/8.0
15 checks passed
fanf
deleted the
bug_23818/import_archive_for_an_existing_technique_delete_the_previous_technique
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23818
We didn't update the status of file in GitArchivers.scala after the compilation was done, and we were basing our cleaning based on the "before compilation" status.
So the main change is to track what files are produce by
ruddercand weave that info up to theGitArchiverwhere we need it to compute the updated status.Appart that, add logs to better understand what is happening for a next time.