Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23852: Make the (now) various Rust CLIs more consistent #5240

Conversation

amousset
Copy link
Member

@amousset amousset commented Dec 8, 2023

https://issues.rudder.io/issues/23852

  • Use a common workspace for all our Rust projects
    • Make the cargo deny configuration common
    • Make the cargo vet configuration common
  • Create a dedicated rudder-cli crate to put common CLI configuration (clap, tracing, etc.)
  • Switch to tracing in rudder-package for consistency
  • Switch relayd to clap to consistency
  • Remove exception in relayd license (was required to link with openssl 1, no need since the relicensing)

@amousset amousset requested a review from Fdall December 8, 2023 00:00
@amousset amousset marked this pull request as draft December 8, 2023 00:00
@amousset amousset removed the request for review from Fdall December 8, 2023 00:00
Fixes #23852: Make the (now) various Rust CLIs more consistent
@amousset
Copy link
Member Author

amousset commented Dec 8, 2023

PR updated with a new commit

…sistent

Fixes #23852: Make the (now) various Rust CLIs more consistent
@amousset
Copy link
Member Author

amousset commented Dec 8, 2023

PR updated with a new commit

…ore consistent

Fixes #23852: Make the (now) various Rust CLIs more consistent
@amousset
Copy link
Member Author

amousset commented Dec 8, 2023

PR updated with a new commit

… CLIs more consistent

Fixes #23852: Make the (now) various Rust CLIs more consistent
@amousset
Copy link
Member Author

amousset commented Dec 9, 2023

PR updated with a new commit

…us Rust CLIs more consistent

Fixes #23852: Make the (now) various Rust CLIs more consistent
@amousset
Copy link
Member Author

amousset commented Dec 9, 2023

PR updated with a new commit

…) various Rust CLIs more consistent

Fixes #23852: Make the (now) various Rust CLIs more consistent
@amousset
Copy link
Member Author

amousset commented Dec 9, 2023

PR updated with a new commit

…he (now) various Rust CLIs more consistent

Fixes #23852: Make the (now) various Rust CLIs more consistent
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset amousset marked this pull request as ready for review December 11, 2023 17:58
@amousset amousset requested a review from Fdall December 11, 2023 17:58
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5240
-- Your faithful QA
Kant merge: "Science is organized knowledge. Wisdom is organized life."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/77344/console)

@amousset amousset merged commit 57109a9 into Normation:master Dec 11, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants