Fixes #23869: Cannot add properties to a group #5245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaadF
added
WIP
VinceMacBuche
approved these changes
Dec 12, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 4575e6d
into
Normation:branches/rudder/8.0
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23869
This bug was introduced by #5236
Since the property module is shared between the node property page and the group property page, we should reflect changes
In #5236 we have renamed the
hasWriteRightsbecause some other module was using the same naming (for AgentSchedule) and was interfering with the write rights for the properties