Fixes #23446: Change request on special:all_nodes_without_role lead to error #5254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
approved these changes
Dec 14, 2023
VinceMacBuche
approved these changes
Dec 14, 2023
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
fanf
deleted the
bug_23446/change_request_on_special_all_nodes_without_role_lead_to_error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23446
I think we don't want to modify event logs (as a general rule). We should perhaps be able to store old event logs in a "cold storage" (other table, or crypted file, or whatever) and wait for old format to disappear.
In the meantime, we will just parse the old and new format (it's extermelly limited in that case, so almost without impact)