Fixes #23932: Plugin license implementation is not coherent with interface #5271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_23932/plugin_license_implementation_is_not_coherent_with_interface
branch
from
9ed8e95
to
e9678ba
Compare
fanf
approved these changes
Dec 19, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 0f29a4d
into
Normation:branches/rudder/7.3
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23932
Some explanation within issue description. The goal here is to be coherent between the trait and all implementation (All to def), this breaks release of some plugins