Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23948: Remove early return to prepare to Scala3 migration in box sequence/traverse #5280

Conversation

fanf
Copy link
Member

@fanf fanf commented Dec 21, 2023

https://issues.rudder.io/issues/23948

This is a backport in 7.3 for #5276

@fanf
Copy link
Member Author

fanf commented Dec 21, 2023

PR updated with a new commit

@mbaechler
Copy link
Contributor

nice

@clarktsiory clarktsiory self-requested a review January 5, 2024 09:21
Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5280
-- Your faithful QA
Kant merge: "Happiness is not an ideal of reason, but of imagination."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/78337/console)

@fanf
Copy link
Member Author

fanf commented Jan 5, 2024

OK, squash merging this PR

@fanf fanf force-pushed the arch_23948/remove_early_return_to_prepare_to_scala3_migration_in_box_sequence_traverse branch from 4f0ccc3 to a3b303e Compare January 5, 2024 09:38
@fanf fanf merged commit a3b303e into Normation:branches/rudder/7.3 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants