New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #23930: lost audit/enforce on the node compliance page #5281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't go that way, it will be too costly. A better fashion would be to extend getNodeComplianceId
to directly have the wanted information.
} | ||
in | ||
req | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to do that. It will be extremely costly when the number of rules/directives growths, especially since we get all rules/directives, and not the ones for the node.
A better approach would be to extends getNodeComplianceId
api to provide the compliance mode - and moreover, I'm pretty sure it's something that would be interesting to have in the public API too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API part is done here : https://github.com/Normation/rudder/pull/5308/files
You can change the decoder at the level of the RuleCompliance
and DirectiveCompliance
data types : just adding a policyMode
field will do, it simplifies also a lot of things in this PR I guess 😄
PR rebased |
fdc29d4
to
7ef3328
Compare
PR updated with a new commit |
PR rebased |
Closing this PR, the fix is done in this other one : #5351 |
https://issues.rudder.io/issues/23930