Fixes #22197: We can accept a node with an existing hostname even if node_accept_duplicated_hostname is false #5284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to make a suggested change through github UI but it made a commit directly (i also tried to make a PR but it failed ....) I may not pass spotless ... |
|
PR updated with a new commit |
VinceMacBuche
approved these changes
Dec 22, 2023
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
…node_accept_duplicated_hostname is false
Fixes #22197: We can accept a node with an existing hostname even if node_accept_duplicated_hostname is false
fanf
force-pushed
the
bug_22197/we_can_accept_a_node_with_an_existing_hostname_even_if_node_accept_duplicated_hostname_is_false
branch
from
79fa107
to
c1c90b9
Compare
fanf
deleted the
bug_22197/we_can_accept_a_node_with_an_existing_hostname_even_if_node_accept_duplicated_hostname_is_false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22197
Not sure what happened in the last refactoring, but here, the failure was yield (as a
Full(Failure(..))in place of being flatMapped.Also: I remove the possibility to write several time the hostname, we know they are all the same, since that's what we are checking.
Finaly, move that check in first place, because it's really useless to move into accepted, then rollback into pending if the hostname is duplicated: just start by checking if it's ok or not to move.