Fixes #23926: Display group compliance #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
commented
Dec 26, 2023
| [ div [class "d-inline-flex align-items-baseline pb-3 w-25"] | ||
| [ | ||
| div [class "btn-group yesno"] | ||
| [ label [class ("btn btn-default" ++ if isGlobalMode then " active" else ""), style "box-shadow" (if isGlobalMode then "inset 0 3px 5px rgba(0,0,0,.125)" else "none"), onClick (LoadCompliance GlobalCompliance)] |
There was a problem hiding this comment.
The styling is done "by-hand" here for testing, it is currently broken since the bootstrap 5 migration, the shadow is no longer present when the button is active...
(This should be fixed globally in another PR)
clarktsiory
force-pushed
the
ust_23926/display_group_compliance
branch
2 times, most recently
from
c01ec26
to
e2f5516
Compare
|
PR updated with a new commit |
|
PR updated with a new commit |
clarktsiory
force-pushed
the
ust_23926/display_group_compliance
branch
from
6fac1e6
to
4b03764
Compare
VinceMacBuche
approved these changes
Dec 29, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 4b03764
into
Normation:master
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23926
Creates an Elm app for display of compliance by group (I copied most of the app structure from directives).
It also changes a bit of Scala frontend code in the summary page of a group, which therefore uses javascript to display compliance (this page has not been rewritten in Elm yet).
There is also some change in the Scala backend to add the policy mode of a rule and a node to the API response.
The 'global' and 'targeted' compliance is specific to groups, and it can be seen as filters for the rules and nodes displayed in the compliance tree :
When the filter value is changed (e.g. from 'global' to 'targeted'), I made the compliance table display in "reload" state until the new compliance data is fetched, as it may take some time for the new data to be shown.