Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #23402: In quicksearch, query error are not displayed which leads to infinite loading result #5295

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fixes #23402: In quicksearch, query error are not displayed which leads to infinite loading result #5295

merged 1 commit into from
Jan 9, 2024

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Dec 28, 2023 •
edited
Loading

https://issues.rudder.io/issues/23402

This formats errors as a nicer message for the user. There is a caveat when doing error transformation from PureResult (Eithers) to Box, which is still the "effect type" in this API : if .toBox is not used at the end, we will end up with a exception cause message being serialized with both err1; cause was : err2 and err2 <- err3 formats...

Screenshot from 2023-12-28 18-32-30

@clarktsiory
Copy link
Contributor Author

Commit modified

@clarktsiory clarktsiory force-pushed the bug_23402/in_quicksearch_query_error_are_not_displayed_which_leads_to_infinite_loading_result branch from 6cc3770 to 127e0bf Compare December 28, 2023 17:46
fanf
fanf approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need a rebase on latest HEAD

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5295
-- Your faithful QA
Kant merge: "Happiness is not an ideal of reason, but of imagination."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/78381/console)

@clarktsiory clarktsiory force-pushed the bug_23402/in_quicksearch_query_error_are_not_displayed_which_leads_to_infinite_loading_result branch from 127e0bf to 1f4b28a Compare January 5, 2024 17:56
@clarktsiory
Copy link
Contributor Author

clarktsiory commented Jan 5, 2024 •
edited
Loading

PR rebased (wrongly on master)

@clarktsiory clarktsiory marked this pull request as draft January 5, 2024 17:57
@clarktsiory clarktsiory force-pushed the bug_23402/in_quicksearch_query_error_are_not_displayed_which_leads_to_infinite_loading_result branch from 1f4b28a to cba507c Compare January 5, 2024 18:06
@clarktsiory clarktsiory marked this pull request as ready for review January 5, 2024 18:09
@clarktsiory
Copy link
Contributor Author

PR rebased successfully

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5295
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/78392/console)

@fanf
Copy link
Member

fanf commented Jan 9, 2024

OK, merging this PR

@fanf fanf merged commit cba507c into Normation:branches/rudder/8.0 Jan 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

@VinceMacBuche VinceMacBuche Awaiting requested review from VinceMacBuche

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@clarktsiory @Normation-Quality-Assistant @fanf