Fixes #24011: Archiving allows to read inconsistent active technique category ids #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Jan 11, 2024
| } | ||
| val target = recNewCategoryDirectory(catId, parents) | ||
|
|
||
| if (target.getCanonicalPath().startsWith(getItemDirectory.getCanonicalPath())) { |
|
PR updated with a new commit |
clarktsiory
commented
Jan 11, 2024
| uptcFile <- newActiveTechniquecFile(uptcId, getParents) | ||
| gitPath = toGitPath(uptcFile) | ||
| // don't forget to delete the category *directory* | ||
| _ <- ZIO.whenZIO(IOResult.attempt(uptcFile.exists)) { |
There was a problem hiding this comment.
Sometimes I added this IOResult.attempt wrapper check over file.exists I/O calls...
fanf
reviewed
Jan 25, 2024
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
|
Added the unit test here, indeed the behavior is changed to raising the error in the |
fanf
approved these changes
Feb 1, 2024
|
This PR is not mergeable to upper versions. |
|
PR rebased |
clarktsiory
force-pushed
the
bug_24011/archiving_allows_to_read_inconsistent_active_technique_category_ids
branch
from
d90d288
to
574a23d
Compare
|
OK, merging this PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24011
A lot of changes but the main one is throwing an error when accessing files outside the root configuration directory in with git (
/var/rudder/configuration-repository) : https://github.com/Normation/rudder/pull/5314/files#diff-bb5734a3493073add0df1291f147ac6cd515b8a211f543610446796ed2374441R169-R187...This should avoid this method to be identified as vulnerable by any smart vulnerability scanners that could also detect the initial vulnerability...