Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24040: Group compliance view does not give global and targeted compliance definitions #5328

Merged
merged 1 commit into from Jan 31, 2024
Merged

Fixes #24040: Group compliance view does not give global and targeted compliance definitions #5328

merged 1 commit into from Jan 31, 2024

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Jan 18, 2024 •
edited

https://issues.rudder.io/issues/24040

Creating the tooltips to explain the meaning of global compliance and targeted compliance :

  • In the compliance tab :
    Screenshot from 2024-01-18 12-22-28

Screenshot from 2024-01-18 11-54-51

  • In the groups parameters tab :
    Screenshot from 2024-01-18 12-35-36

@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

fanf
fanf approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5328
-- Your faithful QA
Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/79522/console)

@fanf
Copy link
Member

fanf commented Jan 31, 2024

OK, squash merging this PR

@fanf fanf force-pushed the bug_24040/group_compliance_view_does_not_give_global_and_targeted_compliance_definitions branch from d603a8f to 01b9c93 Compare January 31, 2024 08:27
@fanf fanf merged commit 01b9c93 into Normation:branches/rudder/8.1 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

@VinceMacBuche VinceMacBuche Awaiting requested review from VinceMacBuche

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@clarktsiory @Normation-Quality-Assistant @fanf