Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24086: You can create a static group which depends on a dynamic one #5353

Merged
merged 1 commit into from Jan 26, 2024
Merged

Fixes #24086: You can create a static group which depends on a dynamic one #5353

merged 1 commit into from Jan 26, 2024

Conversation

fanf
Copy link
Member

@fanf fanf commented Jan 25, 2024 •
edited

https://issues.rudder.io/issues/24086

We don't want to forbid only group changing from dynamic to static to have dynamic subgroup, but anything that is now static.

@fanf fanf requested a review from clarktsiory January 25, 2024 18:15
@clarktsiory
Copy link
Contributor

clarktsiory commented Jan 26, 2024 •
edited

LGTM, but the previous message could be changed :

you can't change the nature of current group to static because it uses following dynamic groups as a subgroup criteria

It is ok when changing the field from "dynamic" to "static" but now we have the same exact error message when assigning an already "static" group to have a "dynamic" subgroup...

@fanf
Copy link
Member Author

fanf commented Jan 26, 2024

PR updated with a new commit

clarktsiory
clarktsiory approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error message is now ok !

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5353
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/79316/console)

@fanf
Copy link
Member Author

fanf commented Jan 26, 2024

OK, squash merging this PR

@fanf fanf force-pushed the bug_24086/you_can_create_a_static_group_which_depends_on_a_dynamic_one branch from 9b3850a to 2aed998 Compare January 26, 2024 14:30
@fanf fanf merged commit 2aed998 into Normation:branches/rudder/7.3 Jan 26, 2024
@fanf fanf deleted the bug_24086/you_can_create_a_static_group_which_depends_on_a_dynamic_one branch March 15, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarktsiory clarktsiory clarktsiory approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@fanf @clarktsiory @Normation-Quality-Assistant