Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24147: Add score enum for score in database #5377

Merged
merged 1 commit into from Feb 7, 2024
Merged

Fixes #24147: Add score enum for score in database #5377

merged 1 commit into from Feb 7, 2024

Conversation

VinceMacBuche
Copy link
Member

@VinceMacBuche VinceMacBuche force-pushed the arch_24147/add_score_enum_for_score_in_database branch from 924a51d to b2b25f4 Compare February 5, 2024 19:02
@VinceMacBuche
Copy link
Member Author

Commit modified

clarktsiory
clarktsiory reviewed Feb 6, 2024
View reviewed changes
...es/rudder/rudder-web/src/main/scala/bootstrap/liftweb/checks/migration/CheckTableScore.scala Outdated
@@ -67,11 +71,14 @@ class CheckTableScore(
nodeId text
, scoreId text
, score text NOT NULL CHECK (score <> '')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, score text NOT NULL CHECK (score <> '')
, score score NOT NULL

@VinceMacBuche
Copy link
Member Author

Commit modified

@VinceMacBuche VinceMacBuche force-pushed the arch_24147/add_score_enum_for_score_in_database branch from b2b25f4 to 931d20e Compare February 6, 2024 10:24
@VinceMacBuche
Copy link
Member Author

PR rebased

@VinceMacBuche VinceMacBuche force-pushed the arch_24147/add_score_enum_for_score_in_database branch from 931d20e to 117bfb8 Compare February 6, 2024 14:43
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 0e30fe5 into Normation:branches/rudder/8.1 Feb 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarktsiory clarktsiory clarktsiory left review comments

@fanf fanf fanf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@VinceMacBuche @Normation-Quality-Assistant @fanf @clarktsiory