Fixes #24124: Links and buttons don't have the right colour since the bootstrap update #5379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24124
There's still a lot of optimisation to be done on this (like replacing all our colour codes with variables, making sure we override as few bootstrap rules as possible but instead using variable overrides, etc.) but to limit its scope I've just fixed and harmonised the appearance of Rudder's main links and buttons.
This first PR already brings a few changes:
There is a new
_rudder-variables.scss
fileWe no longer load the
bootstrap.css
file directly into common-layout.html, instead I've created a newrudder-bootstrap.scss
file into which bootstrap is imported. This allows :