Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24124: Links and buttons don't have the right colour since the bootstrap update #5379

Conversation

RaphaelGauthier
Copy link
Member

@RaphaelGauthier RaphaelGauthier commented Feb 6, 2024

https://issues.rudder.io/issues/24124

There's still a lot of optimisation to be done on this (like replacing all our colour codes with variables, making sure we override as few bootstrap rules as possible but instead using variable overrides, etc.) but to limit its scope I've just fixed and harmonised the appearance of Rudder's main links and buttons.

This first PR already brings a few changes:

  • There is a new _rudder-variables.scss file

    • the underscore means in Sass that this is a "partial" file, i.e. a file that will only be imported into other scss files. It is not compiled in css
    • it will contain all our colour codes (text, buttons, compliance, policy mode, warning/error etc.). Only variables, no css rules!
    • It is completely independent of bootstrap
    • In future, the code in this file will be divided into several partial files, and all these files will be imported into this file, which will serve as the root, to make code maintenance easier.
  • We no longer load the bootstrap.css file directly into common-layout.html, instead I've created a new rudder-bootstrap.scss file into which bootstrap is imported. This allows :

    • cleanly override bootstrap variables
    • have a file where you can find all the overridden bootstrap rules
    • in the future, not to import ALL bootstrap, but only the modules that interest us

@RaphaelGauthier
Copy link
Member Author

Commit modified

@RaphaelGauthier RaphaelGauthier force-pushed the bug_24124/links_and_buttons_don_t_have_the_right_colour_since_the_bootstrap_update branch from e2a562a to 7735d1a Compare February 6, 2024 12:23
@RaphaelGauthier
Copy link
Member Author

Commit modified

@RaphaelGauthier RaphaelGauthier force-pushed the bug_24124/links_and_buttons_don_t_have_the_right_colour_since_the_bootstrap_update branch from 7735d1a to 2314b05 Compare February 6, 2024 12:31
@RaphaelGauthier
Copy link
Member Author

Commit modified

@RaphaelGauthier RaphaelGauthier force-pushed the bug_24124/links_and_buttons_don_t_have_the_right_colour_since_the_bootstrap_update branch from 2314b05 to d795b94 Compare February 6, 2024 12:39
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 2c922ad into Normation:branches/rudder/8.1 Feb 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants