Fixes #4950: move node quicksearch to top-right of rudder #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * It autocompletes on node hostname or id, and redirect | ||
| * to the search node page to display node details. | ||
| */ | ||
| class QuicksearchNode extends DispatchSnippet with Loggable { |
There was a problem hiding this comment.
it should read QuickSearchNode (as for the file name)
|
Francois, it's overall correct, but there are case issue, plus a seemingly unrelated changes |
| @@ -0,0 +1,104 @@ | |||
| /* | |||
There was a problem hiding this comment.
could you rename the file also ?
|
oh, you'll need to rebase this :/ |
|
looks good |
ncharles
added a commit
that referenced
this pull request
Jun 5, 2014
…op_right_of_rudder Fixes #4950: move node quicksearch to top-right of rudder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the node quicksearch field to top right of Rudder.
Take the occasion to clean the nodeSearch page: now, a node details is always displayed from an ajax call.
Also, that ajax call is ALWAYS triggered from the "on hashchange" event, which is now supported for a long time (IE8, Chrome 5, FF3.6, etc). That simplifies a lot the logic of the page.
The stilling was a little ****** to get right.