Fixes #24172: Active buttons no longer have shadow #5386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
requested review from
VinceMacBuche and
RaphaelGauthier
and removed request for
VinceMacBuche
|
PR updated with a new commit |
RaphaelGauthier
approved these changes
Feb 8, 2024
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
clarktsiory
force-pushed
the
bug_24172/active_buttons_no_longer_have_shadow
branch
from
5fa3f35
to
c79abea
Compare
clarktsiory
merged commit c79abea
into
Normation:branches/rudder/8.1
0 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24172
I don't know if the shadow color should go in the
rudder-variablespartial, it seems too specific to be reused anywhere else for now...