Fixes #24178: Initialize score on webapp start up #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
VinceMacBuche
force-pushed
the
enh_24178/initialize_score_on_webapp_start_up
branch
from
76d96a6
to
bc91cdf
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
enh_24178/initialize_score_on_webapp_start_up
branch
from
bc91cdf
to
4071007
Compare
fanf
reviewed
Feb 10, 2024
| ZIO.ifZIO(readScore.getAll().map(_.exists(g => handler.initForScore(g._2))))( | ||
| handler.initEvents.flatMap(ZIO.foreach(_)(handleEvent(_))).unit, | ||
| ().succeed | ||
| ) |
There was a problem hiding this comment.
I think handle event needs to be an `UIO[Unit]. Not catching an error in it leads to unroverable errors and a non working rudder - for ex, when the init event has a problem, it rudder starts but in a bad state .
fanf
force-pushed
the
enh_24178/initialize_score_on_webapp_start_up
branch
from
4071007
to
ef67ddf
Compare
fanf
approved these changes
Feb 10, 2024
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24178
Adds an init sequence for score. especially for system update score. I don't think we need it for compliance since it will initialise very fast for each node (at first agent run/ or even compliance fetch)