Fixes #24176: Directive parameters UI details changed since bootstrap 5 #5400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
force-pushed
the
bug_24176/directive_parameters_ui_details_changed_since_bootstrap_5
branch
from
df24f7c
to
6ce5898
Compare
clarktsiory
commented
Feb 16, 2024
Comment on lines
+103
to
+141
| // -- CHECKBOX/RADIO OVERRIDE | ||
| .checkbox, .radio { | ||
| & { | ||
| position: relative; | ||
| display: block; | ||
| margin-top: 10px; | ||
| margin-bottom: 10px; | ||
| } | ||
|
|
||
| & label { | ||
| cursor: pointer; | ||
| } |
There was a problem hiding this comment.
those are declared in bootstrap 3, disappeared completely in bootstrap 5 😐
RaphaelGauthier
approved these changes
Feb 16, 2024
clarktsiory
force-pushed
the
bug_24176/directive_parameters_ui_details_changed_since_bootstrap_5
branch
from
6ce5898
to
606984c
Compare
|
PR rebased |
|
OK, merging this PR |
clarktsiory
merged commit 606984c
into
Normation:branches/rudder/8.1
4 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24176
Now the directives parameters UI should look very similar to the previous one. Both specific directives html and global css have been changed, but to adapt from previous bootstrap 3 that disappeared in bootstrap 5