Fixes #24209: User sessions should contain the authorizations #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
changed the base branch from
branches/rudder/7.3
to
backports/7.3.12/24146
clarktsiory
commented
Feb 20, 2024
|
|
||
| transactIOResult(s"Error when retrieving information for previous session for '${userId}'")(xa => | ||
| sql.query[UserSession].option.transact(xa) | ||
| ) | ||
| } | ||
|
|
||
| override def deleteOldSessions(olderThan: DateTime): IOResult[Unit] = { | ||
| val sql = sql"""delete from usersessuins where creationdate < ${olderThan}""" |
|
PR updated with a new commit : actually we need distinct authorizations or else the column will be filled with duplicate authz, and it's really hard to do in Java, so I added a |
|
Commit modified |
clarktsiory
force-pushed
the
bug_24209/user_sessions_should_contain_the_authorizations
branch
from
42d45ac
to
2c582f4
Compare
clarktsiory
force-pushed
the
bug_24209/user_sessions_should_contain_the_authorizations
branch
from
2c582f4
to
91c43d5
Compare
VinceMacBuche
merged commit 760a173
into
Normation:backports/7.3.12/24146
10 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24209