Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24283: Margin is too small on Global compliance details module in dashboard #5419

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented Feb 29, 2024

@RaphaelGauthier
Copy link
Member

You should also remove this css rule, in rudder-dashboard.css l.132 :

#globalComplianceStats h4 {
  padding: 0 30px;
}

And add padding: 0 30px; inside #globalComplianceStats rule, l.35 :

#globalComplianceStats {
  color: #36474E;
  padding: 0 30px;
}

This way, padding is always applied to the #globalComplianceStats container, regardless of its content.

@ElaadF ElaadF force-pushed the bug_24283/margin_is_too_small_on_global_compliance_details_module_in_dashboard branch from 4e4e60a to fef3a28 Compare March 7, 2024 08:48
@ElaadF
Copy link
Member Author

ElaadF commented Mar 7, 2024

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5419
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/81208/console)

@ElaadF
Copy link
Member Author

ElaadF commented Mar 8, 2024

OK, merging this PR

@ElaadF ElaadF merged commit 9f23288 into Normation:branches/rudder/8.0 Mar 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants