Fixes #24276: An errors occurs within technique editor resource manager when we create a folder that has the same name than another parent folder #5422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er when we create a folder that has the same name than another parent folder
amousset
approved these changes
Feb 29, 2024
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 0ff6633
into
Normation:branches/rudder/8.0
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24276
We want to reset the current dir of the file manager when opening it. This fix the fact that everyone is lost when using it !
I fixed the recursion problem when a folder had the same name as one of it's parent. It was because a the name of the folder was used as key, so when looking for child file we were getting the parent one, then infinite loop.
I used the full path of the folder instead of just its name