Fixes #24280: When we clone a technique with resource, the clone does not really have the resource #5453
+136
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Mar 7, 2024
| authzToken: AuthzToken | ||
| ): LiftResponse = { | ||
| (for { | ||
| techniqueId <- restExtractorService.extractString("techniqueId")(req)(Full(_)).toIO.notOptional("category parameter is missing") |
There was a problem hiding this comment.
Suggested change
| techniqueId <- restExtractorService.extractString("techniqueId")(req)(Full(_)).toIO.notOptional("category parameter is missing") | |
| techniqueId <- restExtractorService.extractString("techniqueId")(req)(Full(_)).toIO.notOptional("technique id parameter is missing") |
fanf
reviewed
Mar 8, 2024
|
|
||
| IOResult.attempt(s"An error occurred while copying resources of technique ${techniqueId}/${techniqueVersion} to a new draft technique ${draftId}") { | ||
| val resourceDir = gitReposProvider.rootDirectory / s"techniques/${category}/${techniqueId}/${techniqueVersion}/resources" | ||
| val workspace = gitReposProvider.rootDirectory / s"workspace/${draftId}/${techniqueVersion}" |
There was a problem hiding this comment.
please avoid strings for global vars. Ideally they should be services for easier testing, or at lest something provided centrally in an object.
fanf
reviewed
Mar 8, 2024
| @@ -240,6 +241,7 @@ type Msg = | |||
| | UpdateTechnique Technique | |||
| | DeleteTechnique (Result (Http.Detailed.Error String) ( Http.Metadata, TechniqueId )) | |||
| | GetTechniqueResources (Result (Http.Detailed.Error String) ( Http.Metadata, List Resource )) | |||
| | CopyResources (Result (Http.Detailed.Error Bytes) ()) | |||
There was a problem hiding this comment.
I don't get why you have bytes here ? The resources remains in the backend in the case of cloning no ?
There was a problem hiding this comment.
because i don't care about the answer and that's how you do in Elm
|
Can you explain the general idea here ? There's several things I don't get:
|
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_24280/when_we_clone_a_technique_with_resource_the_clone_does_not_really_have_the_resource
branch
from
345484e
to
ae74ad9
Compare
… not really have the resource
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_24280/when_we_clone_a_technique_with_resource_the_clone_does_not_really_have_the_resource
branch
from
ae74ad9
to
d909c07
Compare
|
When I clone a technique with an existing resource, the resource is cloned. But as soons as I try to modify the technique name, I get a lot of error notif in UI, and the following stack trace in logs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24280