-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #24405: Node tabs have onclick event handlers assigned on unrendered elements #5463
Conversation
PR updated with a new commit |
I don't know if it's that PR or if it was like that before, but if the (server) local API is not available, that I get a JS console error in place of a correct error:
The API seems to return an error correctly:
(and then a lot of \u0 which is maybe a problem) |
It works as expected for the "show log" in compliance, but it doesn't seems to do anything for the system status page. Can you check it's OK ? |
It works fine in both tabs on my side, did you have any specific error log in the console for the "System status" tab ? |
Also, running the previous version also return the |
OK, finally understood: I had a previous version of the PR :) |
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
7458ccb
to
793a058
Compare
https://issues.rudder.io/issues/24405
We display the
logs
table in two different tabsCompliance
andSystem status
, but having the sameid
for different elements across tables makes it impossible to dispatch event handlers correctly.Also, the event handlers are not set on the
Show logs
buttons because the tab is has not yet been rendered.We just append the tab id to every HTML element, and set the buttons HTML with the correct event handler when the tab is rendered.