-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #24236: Overriding properties should have the same type as overridden #5471
Fixes #24236: Overriding properties should have the same type as overridden #5471
Conversation
7e838ff
to
a3afdc0
Compare
PR updated with a new commit |
1 similar comment
PR updated with a new commit |
PR updated with a new commit |
PR updated with a new commit |
Tests are failing, I'm fixing them |
PR updated with a new commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and it's a really nice feature. Having the list of faulty nodes in groups is very cool.
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
ef8436e
to
88d2746
Compare
https://issues.rudder.io/issues/24236
Add a warning field for when a property has some conflict over it's "type hierarchy".
It can be seen in node properties tabs, in different cases :
when creating a new property (but we try to infer the property type when we can here) :
![image](https://private-user-images.githubusercontent.com/65616064/312942000-f840680b-7280-4908-9398-309942ca3ca9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM2OTUwNzUsIm5iZiI6MTcyMzY5NDc3NSwicGF0aCI6Ii82NTYxNjA2NC8zMTI5NDIwMDAtZjg0MDY4MGItNzI4MC00OTA4LTkzOTgtMzA5OTQyY2EzY2E5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE1VDA0MDYxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI5ZjQzYzJjOTlmNGQ2ZmE3MGYzMDhmYWUxNzg4N2UyODc2ZTJhOTk3NTMwYzc1MmM3MzcwNDczNDY4N2NjYWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.m86nqfRuCmO9S5mWQnwX-6NbTK5LGqcMd3ux2whuOxM)
when editing an existing property :
![image](https://private-user-images.githubusercontent.com/65616064/312938107-dadbf468-d841-4257-91b0-b443f8da9e06.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM2OTUwNzUsIm5iZiI6MTcyMzY5NDc3NSwicGF0aCI6Ii82NTYxNjA2NC8zMTI5MzgxMDctZGFkYmY0NjgtZDg0MS00MjU3LTkxYjAtYjQ0M2Y4ZGE5ZTA2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE1VDA0MDYxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFhMjA0ZmNhMGUxNGUwZDAwZWYwYmZhMTBjZGJlMzBiNTY0NTU5MGIzYjljNmZkZjExNmYwYjc5YjhlNTY4YTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ekzwMZA7r53GTp2GZWTvQua_WEsMA5fJ_ENTIc57iBE)
when node property already exists and has type hierarchy conflicts :![image](https://private-user-images.githubusercontent.com/65616064/312903876-9dbb4926-e6a3-4044-bc95-45336852eee4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM2OTUwNzUsIm5iZiI6MTcyMzY5NDc3NSwicGF0aCI6Ii82NTYxNjA2NC8zMTI5MDM4NzYtOWRiYjQ5MjYtZTZhMy00MDQ0LWJjOTUtNDUzMzY4NTJlZWU0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE1VDA0MDYxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY1MWZiMTg3ZWI1NDdlYjE2MDE0Yzg4ZWE1MmZiZmYyOGViNDBiOGE0Mjg2MzNlMzM5YjQzOWE4NmQ3Yjc2MTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.vXAlOvnuOXu1NojXrMZdyy6lhmG_gck9SQhz1crFmd0)
N.B. : The feature is available in both "node" and "group" details.