Fixes #24236: Overriding properties should have the same type as overridden #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
force-pushed
the
bug_24236/overriding_properties_should_have_the_same_type_as_overridden
branch
from
7e838ff
to
a3afdc0
Compare
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
|
PR updated with a new commit |
|
PR updated with a new commit |
|
Tests are failing, I'm fixing them |
|
PR updated with a new commit |
fanf
approved these changes
Mar 18, 2024
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_24236/overriding_properties_should_have_the_same_type_as_overridden
branch
from
ef8436e
to
88d2746
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24236
Add a warning field for when a property has some conflict over it's "type hierarchy".
It can be seen in node properties tabs, in different cases :
when creating a new property (but we try to infer the property type when we can here) :
when editing an existing property :
when node property already exists and has type hierarchy conflicts :
N.B. : The feature is available in both "node" and "group" details.