Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24456: Missing primary key statement for user sessions table creation when migrating #5472

Conversation

fanf
Copy link
Member

@fanf fanf commented Mar 14, 2024

https://issues.rudder.io/issues/24456

What is in the migration and in SQL is not synched. We need to find a way to make it synched, else we will have things like that all the time.

So:

  • correct the initial migration of the table
  • add a bit of script to add primary relation if it doesn't exists

@fanf fanf requested a review from clarktsiory March 14, 2024 15:50
Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@fanf
Copy link
Member Author

fanf commented Mar 14, 2024

PR updated with a new commit

1 similar comment
@fanf
Copy link
Member Author

fanf commented Mar 14, 2024

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5472
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/81530/console)

@fanf
Copy link
Member Author

fanf commented Mar 14, 2024

OK, squash merging this PR

@fanf fanf force-pushed the bug_24456/missing_primary_key_statement_for_user_sessions_table_creation_when_migrating branch from 3b85ed1 to 228c36a Compare March 14, 2024 17:31
@fanf fanf merged commit 228c36a into Normation:branches/rudder/7.3 Mar 14, 2024
7 of 15 checks passed
@fanf fanf deleted the bug_24456/missing_primary_key_statement_for_user_sessions_table_creation_when_migrating branch March 15, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants