Fixes #24416: Elm properties app is loaded multiple times #5477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24416
The fix consist of :
So we just move everything related to the Elm app "earlier" in the HTML structure, from
NodeGroupForm
details to the mainGroup
page.Caveats of this is that a new Elm app will be initialized each time the "Properties" tab is shown, but changing the Elm model to re-render with every group change action is heavier (we would likely need to make Elm apps global variables, to call ports on every action from the Scala templates). We could do that in another PR.